mcpField
A
advpl-code-review

advpl-code-review

github.com/thalysjuvenalTesting & quality19150 installsUpdated 6w ago
Repository

About advpl-code-review

A code review skill for existing ADVPL and TLPP projects, aimed at developers assessing quality, security, performance, and modernization. Findings include rule IDs, severity, location, issue details, and suggested fixes, with optional mapping to the TOTVS SonarQube quality gate.

Key features

  1. 01Best-practice checks
  2. 02Performance and security reviews
  3. 03Modernization assessment
  4. 04Rule IDs and severity levels
  5. 05TOTVS SonarQube rule mapping

Use cases

  1. 01Reviewing changes before a merge
  2. 02Checking code before deployment
  3. 03Auditing a codebase during onboarding
  4. 04Assessing readiness for TLPP migration

Install

Copy the command and run it in a terminal.

$npx skills add https://github.com/thalysjuvenal/advpl-specialist --skill advpl-code-review

After installing, type/advpl-code-reviewin Claude Code to confirm it loaded.

Bundled files

References and scripts installed along with SKILL.md.

reference.md
rules-best-practices.md
rules-modernization.md
rules-performance.md
rules-security.md
sonarqube-rules-catalog.md

Details

From the project README

ADVPL/TLPP Code Review

This skill provides a systematic code review methodology for existing ADVPL/TLPP code, producing findings tagged with a rule ID (BP-*, PERF-*, SEC-*, MOD-*), a severity (CRITICAL/WARNING/INFO), the file/line, the issue, and the fix. It covers four review categories: best practices, performance, security, and modernization, and can map findings to the official TOTVS SonarQube quality gate.

Activate this skill when the user wants existing code inspected for quality, compliance, security, or performance issues -- e.g. before a merge, before a deploy, during an onboarding audit, or when assessing migration readiness from .prw to .tlpp. It does not cover generating new code (see advpl-code-generation), diagnosing a specific runtime/compilation error (see advpl-debugging), restructuring code without adding features (see advpl-refactoring), or performing the actual .prw to .tlpp conversion (see advpl-to-tlpp-migration).

Reference fileRead when
reference.mdAlways -- review categories, output format, severity levels, review process, rule ID prefixes
rules-best-practices.mdChecking RecLock/MsUnlock pairing, variable scope, area management, error handling, documentation (BP-* rules)
rules-performance.mdChecking Embedded SQL efficiency, loop efficiency, string operations, index usage (PERF-* rules)
rules-security.mdChecking SQL injection, input validation, credential exposure, sensitive data logging (SEC-* rules)
rules-modernization.mdChecking TLPP migration candidates, namespace usage, OOP patterns, modern UI frameworks (MOD-* rules)
sonarqube-rules-catalog.mdAligning findings with the official TOTVS SonarQube ruleset (groups G1-G5, CA/BG/CS codes)

Comments

Markdown supported