About code-review
code-review is a skill that guides reviews of code changes, covering defects, design, tests, security, and long-term risks. It also sets expectations for actionable, empathetic feedback and risk-focused approvals.
Key features
- 01Check runtime and performance risks
- 02Assess side effects and compatibility
- 03Review security and ORM query concerns
- 04Evaluate design and test coverage
- 05Flag changes needing senior review
Use cases
- 01Review a pull request for security gaps
- 02Assess tests for critical paths and edge cases
- 03Identify risks in schema or API changes
Install
Copy the command and run it in a terminal.
$
npx skills add https:/ / github.com/ millionco/ expect --skill code-reviewAfter installing, type/code-reviewin Claude Code to confirm it loaded.
Details
From the project READMECode Review
Follow these guidelines when reviewing code.
Review Checklist
Identifying Problems
Look for these issues in code changes:
- Runtime errors: Potential exceptions, null pointer issues, out-of-bounds access
- Performance: Unbounded O(n²) operations, N+1 queries, unnecessary allocations
- Side effects: Unintended behavioral changes affecting other components
- Backwards compatibility: Breaking API changes without migration path
- ORM queries: Complex Django ORM with unexpected query performance
- Security vulnerabilities: Injection, XSS, access control gaps, secrets exposure
Design Assessment
- Do component interactions make logical sense?
- Does the change align with existing project architecture?
- Are there conflicts with current requirements or goals?
Test Coverage
Every PR should have appropriate test coverage:
- Functional tests for business logic
- Integration tests for component interactions
- End-to-end tests for critical user paths
Verify tests cover actual requirements and edge cases. Avoid excessive branching or looping in test code.
Long-Term Impact
Flag for senior engineer review when changes involve:
- Database schema modifications
- API contract changes
- New framework or library adoption
- Performance-critical code paths
- Security-sensitive functionality
Feedback Guidelines
Tone
- Be polite and empathetic
- Provide actionable suggestions, not vague criticism
- Phrase as questions when uncertain: "Have you considered...?"
Approval
- Approve when only minor issues remain
- Don't block PRs for stylistic preferences
- Remember: the goal is risk reduction, not perfect code
Comments
Markdown supported