mcpField
C
code-review

code-review

github.com/srbhrTesting & quality28.9k54 installsUpdated 1w ago
Repository

About code-review

A code-review skill for evaluating changes against the project's FastAPI, Next.js, and security conventions. It provides checklists, severity labels, and a verify-before-implement response process.

Key features

  1. 01Backend review checklist
  2. 02Frontend review checklist
  3. 03Security checks
  4. 04Severity labels for findings
  5. 05Verify-before-implement process

Use cases

  1. 01Reviewing FastAPI changes
  2. 02Checking Next.js code conventions
  3. 03Assessing input validation and endpoint security

Install

Copy the command and run it in a terminal.

$npx skills add https://github.com/srbhr/resume-matcher --skill code-review

After installing, type/code-reviewin Claude Code to confirm it loaded.

Details

From the project README

Code Review

Code review requires technical evaluation, not emotional performance.

Core principle: Verify before implementing. Ask before assuming. Technical correctness over social comfort.

Review Checklist

Backend (Python/FastAPI)
  • All functions have type hints
  • copy.deepcopy() for mutable defaults
  • Error handling: detailed logs server-side, generic messages to clients
  • API keys via api_key= parameter, not os.environ
  • Async functions for I/O operations
  • Pydantic schemas for request/response bodies
  • No blocking calls in async routes
  • asyncio.Lock() for shared resource initialization
Frontend (Next.js/React)
  • Swiss International Style compliance
  • rounded-none everywhere
  • Textareas have Enter key handler
  • Direct icon imports (not barrel)
  • next/dynamic for heavy components
  • Promise.all() for independent fetches
  • Server Actions check auth inside
Security
  • No secrets in code
  • Input validation on user data
  • CORS configured properly
  • Auth checks on protected endpoints

Response Pattern

WHEN receiving feedback:
1. READ: Complete feedback without reacting
2. UNDERSTAND: Restate requirement in own words
3. VERIFY: Check against codebase reality
4. EVALUATE: Technically sound for THIS codebase?
5. RESPOND: Technical acknowledgment or reasoned pushback
6. IMPLEMENT: One item at a time, test each

Forbidden Responses

  • "You're absolutely right!" (performative)
  • "Great point!" (performative)
  • "Let me implement that now" (before verification)

When to Push Back

  • Suggestion breaks existing functionality
  • Reviewer lacks full context
  • Violates YAGNI (unused feature)
  • Technically incorrect for this stack
  • Conflicts with architectural decisions

Severity Format

[CRITICAL] file:line - Security, data loss, crash
[ERROR]    file:line - Bug, missing validation
[WARNING]  file:line - Style, convention
[INFO]     file:line - Suggestion, not required

References

  • Backend guide: docs/agent/architecture/backend-guide.md
  • Coding standards: docs/agent/coding-standards.md
  • Style guide: docs/agent/design/style-guide.md

Comments

Markdown supported