mcpField
G
generic-code-reviewer

generic-code-reviewer

github.com/travisjneumanTesting & quality106142 installsUpdated 1d ago
Repository

About generic-code-reviewer

A general code review skill for developers assessing changes across different technology stacks against production quality standards. It detects the stack from project files and organizes security, correctness, performance, accessibility, and code quality issues by P0, P1, and P2 priority.

Key features

  1. 01Technology stack detection from project files
  2. 02Project CLAUDE.md rule checks
  3. 03P0, P1, and P2 issue prioritization
  4. 04Security and correctness checks
  5. 05Performance, accessibility, and code quality checks

Use cases

  1. 01Reviewing code changes before merge
  2. 02Checking security and edge cases
  3. 03Organizing findings by severity

Install

Copy the command and run it in a terminal.

$npx skills add https://github.com/travisjneuman/.claude --skill generic-code-reviewer

After installing, type/generic-code-reviewerin Claude Code to confirm it loaded.

Details

From the project README

Generic Code Reviewer

Review code against production quality standards. Adapts to any project's tech stack.

Full Standards: See Code Review Standards

CLAUDE.md Compliance

Always check the project's CLAUDE.md for specific rules.

Before ANY Commit:

  • Task file exists in tasks/[feature-name].md
  • Diff reviewed against the request, callers, and edge cases
  • No console errors/warnings
  • Bundle size within limits

Tech Stack Detection

DetectionStackKey Checks
React in package.jsonReact/TSComponents, hooks, state
Next.js in package.jsonNext.jsSSR, API routes
NestJS in package.jsonNestJSGuards, DTOs, services
.html files, no buildVanillaSemantic HTML, minimal JS
.py filesPythonType hints, validation

P0 Issues (Block Merge)

Security - Frontend
  • Sanitize input (textContent, not innerHTML)
  • unknown type for external data
  • No exposed API keys
  • HTTPS for external requests
Security - Backend
  • Input validation on all endpoints
  • Auth on protected routes
  • Parameterized queries (no raw SQL)
  • Secrets in environment variables
Correctness
  • Logic errors that break functionality
  • Type errors in strict mode
  • Unhandled promise rejections

P1 Issues (Should Fix)

Performance
Project TypeTarget
Static site< 50KB (excluding media)
SPA/React< 100KB gzipped initial
Full-stack< 200KB gzipped initial

Animation:

  • GPU-accelerated only (transform, opacity)
  • 60fps target
  • Use requestAnimationFrame
Accessibility (WCAG AA)
  • Focus indicators on interactive elements
  • Keyboard navigation (Tab, Enter, Escape)
  • Color contrast >= 4.5:1
  • ARIA labels on icon-only buttons
  • Alt text for meaningful images
  • Semantic HTML structure

P2 Issues (Nice to Have)

Code Quality
  • DRY, Single Responsibility
  • No magic numbers/strings
  • Self-documenting code
  • Follow existing patterns
  • No commented-out/dead code

Review Output Format

Only report issues found (don't list empty categories):

Blocking Issues (P0):

  • [Only if found - security, correctness issues]

Should Fix (P1):

  • [Only if found - performance, accessibility issues]

Consider (P2):

  • [Only if found - code quality polish]

If no issues: "Code review passed. Ready to merge."

Judgment Calls

When user asks "Is this OK?", consider:

ContextStricterMore Lenient
EnvironmentProductionPrototype/POC
PathHot path, frequently executedOne-time setup, admin only
VisibilityPublic API, external interfaceInternal helper, private method
TimelineFeature completeActive iteration

Adjust severity accordingly. P0 security issues are never lenient.

Quick Checklist

Pre-Commit:

  • Diff reviewed (inputs, edge cases, error paths, callers)
  • No console errors

Before Merge:

  • All P0 issues resolved
  • P1 issues addressed or tracked
  • P2 issues noted for future

See Also

Comments

Markdown supported