About reviewing-code
A code-review skill for people seeking feedback on code quality. It guides reviewers through correctness, maintainability, performance, TypeScript safety, and tests, then organizes findings by severity with locations and suggested fixes.
Key features
- 01Review correctness and edge cases
- 02Assess maintainability and performance
- 03Check TypeScript type safety
- 04Evaluate test coverage
- 05Rank findings by severity
Use cases
- 01Review a feature or bug-fix diff
- 02Find error-handling and async risks
- 03Assess performance and maintainability
- 04Report actionable code-quality feedback
Install
Copy the command and run it in a terminal.
npx skills add https:/ / github.com/ revitalb-port/ skills-registry-demo --skill reviewing-codeAfter installing, type/reviewing-codein Claude Code to confirm it loaded.
Details
From the project READMECode Review
Use this skill when the user asks for a code review, feedback on their code, or to check code quality.
Steps
-
Understand the change — read the files or diff to understand what the code is supposed to do. Identify the scope (new feature, bug fix, refactor).
-
Check correctness
- Does the code handle edge cases (empty input, null, zero, negative numbers)?
- Are error states handled (try/catch, error boundaries, fallback UI)?
- Does async code handle race conditions, cancellation, and timeouts?
- Are there off-by-one errors in loops or array access?
-
Check maintainability
- Are functions focused on a single responsibility?
- Are variable and function names descriptive?
- Is there unnecessary duplication that should be extracted?
- Are magic numbers replaced with named constants?
- Is the code complexity reasonable (deeply nested conditionals, long functions)?
-
Check performance
- Are there N+1 query patterns in database access?
- Are expensive computations or API calls happening in render loops?
- Are large lists missing virtualization or pagination?
- Are there missing indexes for common database queries?
- Is memoization used appropriately (not over-applied)?
-
Check type safety (TypeScript projects)
- Are there
anytypes that should be narrowed? - Are function return types explicit for public APIs?
- Are union types handled exhaustively?
- Are there
-
Check testing
- Are there tests for the new/changed code?
- Do tests cover the happy path AND error cases?
- Are tests isolated (no shared mutable state)?
-
Provide feedback — organize findings by severity:
- Must fix: bugs, security issues, data loss risks
- Should fix: performance issues, maintainability concerns
- Nit: style preferences, minor suggestions
For each finding, include the file, line, the issue, and a suggested fix.
Notes
- Be constructive — explain why something is a problem, not just that it is.
- Acknowledge what's done well, not just what needs fixing.
- Don't bikeshed on style issues that a linter/formatter should handle.